Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consistencies across all factions #5954

Merged
merged 14 commits into from Mar 12, 2024
Merged

Conversation

MrRowey
Copy link
Member

@MrRowey MrRowey commented Mar 4, 2024

Fix Inconsistencies with #5764 that changes backup distance but doesn't copy the same changes across to the same units from different factions Unify this so make sure that the changes are consistent

Fix Inconsistencies with #5764 that changes back up distance but didn't copy the same changes across to the same units from different factions this Unify this so make sure that the chnages are conisisten
@MrRowey MrRowey added the area: unit-blueprint related to issues in unit blueprints (*_unit.bp) label Mar 4, 2024
@MrRowey MrRowey requested a review from Garanas March 4, 2024 10:42
@Basilisk3
Copy link
Contributor

Are you sure you want to add backup distances to legged units? I didn't do that in my PR because the animation looks off when units that do not use tracks for locomotion use it. You also doubled the MaxSpeedReverse for the Megalith, that is a considerable buff.

@MrRowey
Copy link
Member Author

MrRowey commented Mar 4, 2024

Are you sure you want to add backup distances to legged units? I didn't do that in my PR because the animation looks off when units that do not use tracks for locomotion use it. You also doubled the MaxSpeedReverse for the Megalith, that is a considerable buff.

Fair points maid feel free to revert the changes I've made to mega and legged units for now

@Garanas
Copy link
Member

Garanas commented Mar 4, 2024

To me it's better to get the existing changes live before we tweak them further.

@MrRowey
Copy link
Member Author

MrRowey commented Mar 4, 2024

To me it's better to get the existing changes live before we tweak them further.

a lot of the changes I've made here are to go alone side the existing one as their were either just missed or not done and this aims to make sure that it certain units all have the same feeling when their moving.

Copy link
Contributor

@Basilisk3 Basilisk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the addition of BackUpDistances to legged units and the change to the MaxSpeedReverse of the Megalith.

units/XRL0403/XRL0403_unit.bp Outdated Show resolved Hide resolved
units/DALK003/DALK003_unit.bp Outdated Show resolved Hide resolved
units/DALK003/DALK003_unit.bp Outdated Show resolved Hide resolved
units/DRLK001/DRLK001_unit.bp Outdated Show resolved Hide resolved
units/DRLK001/DRLK001_unit.bp Outdated Show resolved Hide resolved
units/URL0107/URL0107_unit.bp Outdated Show resolved Hide resolved
units/URL0107/URL0107_unit.bp Outdated Show resolved Hide resolved
units/XRL0305/XRL0305_unit.bp Outdated Show resolved Hide resolved
units/XSL0104/XSL0104_unit.bp Outdated Show resolved Hide resolved
units/XSL0202/XSL0202_unit.bp Outdated Show resolved Hide resolved
MrRowey and others added 13 commits March 4, 2024 21:30
Co-authored-by: Basilisk3 <126026384+Basilisk3@users.noreply.github.com>
Co-authored-by: Basilisk3 <126026384+Basilisk3@users.noreply.github.com>
Co-authored-by: Basilisk3 <126026384+Basilisk3@users.noreply.github.com>
Co-authored-by: Basilisk3 <126026384+Basilisk3@users.noreply.github.com>
Co-authored-by: Basilisk3 <126026384+Basilisk3@users.noreply.github.com>
Co-authored-by: Basilisk3 <126026384+Basilisk3@users.noreply.github.com>
Co-authored-by: Basilisk3 <126026384+Basilisk3@users.noreply.github.com>
Co-authored-by: Basilisk3 <126026384+Basilisk3@users.noreply.github.com>
Co-authored-by: Basilisk3 <126026384+Basilisk3@users.noreply.github.com>
Co-authored-by: Basilisk3 <126026384+Basilisk3@users.noreply.github.com>
Co-authored-by: Basilisk3 <126026384+Basilisk3@users.noreply.github.com>
Co-authored-by: Basilisk3 <126026384+Basilisk3@users.noreply.github.com>
Co-authored-by: Basilisk3 <126026384+Basilisk3@users.noreply.github.com>
@MrRowey
Copy link
Member Author

MrRowey commented Mar 4, 2024

@Garanas can this get merged before the release

@Garanas Garanas added the feature: pathfinding related to pathfinding label Mar 12, 2024
@Garanas Garanas merged commit 6f4f31d into deploy/fafdevelop Mar 12, 2024
3 checks passed
@Garanas Garanas deleted the backup-distances branch March 12, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: unit-blueprint related to issues in unit blueprints (*_unit.bp) feature: pathfinding related to pathfinding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants