Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 'BUILTBYEXPERIMENTALSUB' category from various units #6005

Merged
merged 9 commits into from Mar 21, 2024

Conversation

Basilisk3
Copy link
Contributor

@Basilisk3 Basilisk3 commented Mar 19, 2024

Description of the proposed changes

Removes the BUILTBYEXPERIMENTALSUB category from various units.

Testing done on the proposed changes

The Tempest can still build these units just fine. Except units like the Seraphim cruiser of course, interestingly enough, this unit also had the category.

Additional context

According to @The-Balthazar on Discord, this category is unused.

Checklist

  • Changes are documented in the changelog for the next game version

@Garanas Garanas added the area: unit categories related to unit categories defined in the blueprint files label Mar 20, 2024
@Garanas Garanas merged commit e4e4c7f into FAForever:deploy/fafdevelop Mar 21, 2024
@Basilisk3 Basilisk3 deleted the remove_unused_category branch March 21, 2024 08:22
@The-Balthazar
Copy link
Contributor

If the Tempest ever used BUILTBYEXPERIMENTALSUB, it was in the original beta. In SupCom1 it's got the same build categories as it does in FA. BUILTBYEXPERIMENTALSUB exists in a lot of mods, but because they uncritically copied the blueprints of the units this PR removes it from, not because they planned to use it; same reason non-Aeon FA units appear to have it, at least as far as my searches have gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: unit categories related to unit categories defined in the blueprint files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants