Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust 'BOMB' category usage and add torpedo/normal bomber selection hotkeys #6009

Merged
merged 9 commits into from
Mar 23, 2024

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Mar 20, 2024

Description of the proposed changes

Closes #5298. Reduces the need to manually filter after using the select all bombers hotkey. Could be done with game.prefs editing instead, but it seems useful enough to be a default available to all players.
BOMB category and Suicide Weapon ability text removed from Loyalist because it no longer has the self-destructing charge ability.
BOMB category added to Mercy because it has to die to attack, just like the fire beetle.

Testing done on the proposed changes

Spawned all torpedo bombers and all bombers + mercy. Pressing the select all bombers (non-torpedo) hotkey selects all normal bombers. Pressing the select all bombers (torpedo) hotkey selects all torpedo bombers. Mercy does not get selected.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@lL1l1 lL1l1 added feature: hotkeys related to miscellaneous hotkeys area: unit categories related to unit categories defined in the blueprint files labels Mar 20, 2024
@relent0r
Copy link
Contributor

Nice change on the Mercy. Until now if I want to capture all MOBILE AIR BOMBER I've always had to exclude the Mercys unit id since from a category perspective you can't tell the difference.

@Garanas
Copy link
Member

Garanas commented Mar 21, 2024

@lL1l1 can you add the category and descriptions for the new hotkeys to the changelog? That way players do not have to go searching for them

@lL1l1
Copy link
Contributor Author

lL1l1 commented Mar 21, 2024

One thing I noticed is that this would make it more difficult to identify Loyalist's death weapon usage since there's no category for it anymore. BOMB is for suicide weapons, and VOLATILE is for units who's death effects should be stopped by reclaiming (this doesn't work though). VOLATILE category is also a separate definition from the ability text displayed in the UI, which just means a unit has a death weapon.

@Garanas Garanas merged commit d16448b into FAForever:deploy/fafdevelop Mar 23, 2024
@lL1l1 lL1l1 deleted the UI/torp-bomb-hotkeys branch April 1, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: unit categories related to unit categories defined in the blueprint files feature: hotkeys related to miscellaneous hotkeys
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add two new hotkeys for different type of bombers
3 participants