Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CZAR categories - remove antinavy and add weakantinavy #6012

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

relent0r
Copy link
Contributor

Description of the proposed changes

This PR changes the previously added category of ANTINAVY to WEAKANTINAVY.

After some discussion I realised that non primary weapon types for units should have the weak variant of the category.

@relent0r relent0r changed the title CZR categories - remove antinavy and add weakantinavy CZAR categories - remove antinavy and add weakantinavy Mar 20, 2024
@Garanas Garanas added the area: unit categories related to unit categories defined in the blueprint files label Mar 21, 2024
@Garanas
Copy link
Member

Garanas commented Mar 21, 2024

Relates to #5988

@Garanas
Copy link
Member

Garanas commented Mar 21, 2024

@relent0r could you add and/or update the entry in the changelog of the previous pull request? It is inside /changelogs/3804.md

@relent0r
Copy link
Contributor Author

@relent0r could you add and/or update the entry in the changelog of the previous pull request? It is inside /changelogs/3804.md

You've just got it listed as Add missing categories to the CZAR, so it still applies the same. (tho didn't realise we were updating the change log when doing PRs so good to know)

@Garanas
Copy link
Member

Garanas commented Mar 21, 2024

That is very recent - since a week. It's an experiment to see if we can build up the changelog as we make the changes instead of me spending several hours crunching the notes together right before a release 😃

@Garanas Garanas merged commit 31772f0 into FAForever:deploy/fafdevelop Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: unit categories related to unit categories defined in the blueprint files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants