Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exploit with the Copy/Distribute orders feature #6013

Merged
merged 6 commits into from
Mar 23, 2024

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Mar 20, 2024

Description of the proposed changes

One can copy the command queue of another unit and append it to the command queue of the units in your selection. In Discord people noticed that this effectively allowed you to copy attack commands that are assigned to units that you no longer have vision over.

That exploit is now fixed.

Testing done on the proposed changes

image

Have a group of units constantly go in and out of (radar) vision. The orders should only be copied when the attack commands are visible to the player.

Additional context

See the following Discord thread

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@Garanas Garanas added the feature: distribute orders related to distribute orders functionality label Mar 20, 2024
@Garanas Garanas changed the title Fix exploit with the Copy orders feature Fix exploit with the Copy/Distribute orders feature Mar 20, 2024
@Pokute
Copy link
Contributor

Pokute commented Mar 20, 2024

Does this affect only order copying/distributing or does this affect issuing attack commands in general?

If latter, then this will very likely affect negatively AI/single player/scenarios.

@Garanas
Copy link
Member Author

Garanas commented Mar 20, 2024

This only affects features that rely on the mapping provided in lua/sim/commands/shared.lua, which is only used by the copy/distribute queue orders if I'm not mistaken 😃

@Garanas Garanas marked this pull request as ready for review March 23, 2024 12:44
@Garanas Garanas merged commit bb20b3a into deploy/fafdevelop Mar 23, 2024
3 checks passed
@Garanas Garanas deleted the Fix/copy-orders-exploit branch March 23, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: distribute orders related to distribute orders functionality type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants