Fix exploit with the Copy/Distribute orders
feature
#6013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
One can copy the command queue of another unit and append it to the command queue of the units in your selection. In Discord people noticed that this effectively allowed you to copy attack commands that are assigned to units that you no longer have vision over.
That exploit is now fixed.
Testing done on the proposed changes
Have a group of units constantly go in and out of (radar) vision. The orders should only be copied when the attack commands are visible to the player.
Additional context
See the following Discord thread
Checklist