Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various smaller fixes for unitviewDetail.lua #6037

Merged
merged 4 commits into from Apr 1, 2024

Conversation

Basilisk3
Copy link
Contributor

@Basilisk3 Basilisk3 commented Apr 1, 2024

Description of the proposed changes

1. The Range and Reload stats should not be displayed for Teleport in weapons, as they do not make sense here. Also remove the Reload stat from Kamikaze weapons.

The old output for Teleport in weapons:

Teleport in (Teleport) (Manual Fire)
Damage: 100, Splash: 4, Range: 0 - 1, Reload: 1.$

The new output for Teleport in weapons:

Teleport in (Teleport) (Manual Fire)
Damage: 100, Splash: 4

2. Move the Teleport in weapons of Personal Teleporters to Upgrades, as this form of damage is only accessible via the enhancement after the initial gate-in.

3. Clarify the number of available enhancements.

4. Change the color of the DamageType Overcharge to green; change the color of Kamikaze weapons to a deeper shade of red.

5. Exclude countermeasures like Torpedo and Missile Defenses from DPS calculations

Additional context

Concerning the Teleport in damage: Technically Damage: 100 is wrong, it does 101 damage.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@Basilisk3 Basilisk3 marked this pull request as draft April 1, 2024 15:34
@Basilisk3 Basilisk3 marked this pull request as ready for review April 1, 2024 17:49
@Basilisk3
Copy link
Contributor Author

Basilisk3 commented Apr 1, 2024

I also removed the DPS stat from TMDs and Torpedo Defenses now, as it's not useful.

@lL1l1
Copy link
Contributor

lL1l1 commented Apr 1, 2024

Aeon TMD uses a 'Defense' WeaponCategory without the 'UWRC_Countermeasure' range category.

@lL1l1 lL1l1 merged commit 0f75715 into FAForever:deploy/fafdevelop Apr 1, 2024
@Basilisk3 Basilisk3 deleted the uvd2 branch April 25, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants