Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCU Changes #6092

Draft
wants to merge 29 commits into
base: deploy/fafdevelop
Choose a base branch
from
Draft

SCU Changes #6092

wants to merge 29 commits into from

Conversation

MrRowey
Copy link
Member

@MrRowey MrRowey commented Apr 17, 2024 •
edited

closes #6126

Checklist

All

  • MassCost: 2k
  • EnergyCost: 30k
  • BuildRate: 40
  • BuildTime: 14500
  • Health: +2.5k from ACU Base HP
  • Regen: +5 from ACU Base RegenHP
  • Death Dmg: 1000 > 2500
  • Gun Dmg: 56 > 40

UEF

  • Add Passive Jammer Support

Engineer Drone

  • Drone BR: 35 > 55
  • SCU BR: 40 > 45
  • MassCost: 380 > 450
  • EnergyCost: 8700 > 9400

Energy Accelerator

  • Damage: +200

Cybran

  • Add Passive Stealth Support

Rapid Fab

  • MassCost: 800 > 600
  • EnergyCost: 40k > 35k

EMP Burst

  • Damage: +200

Aeon

  • Add Passive Regen Field

Rapid Fab

  • MassCost: 800 > 600
  • EnergyCost: 40k > 35k

Reactron Refractor

  • Damage: +200

Sacrifice

  • Remove Upgrade > Intergrade to Base SCU

Seraphim

  • Add Passive Regen Field

Rapid Fab

  • MassCost: 800 > 600
  • EnergyCost: 40k > 35k

Teleport

  • Slot: Right > Back

Gun damage Upgrade

  • Damage: 100 > 400

Changelog

  • Changes are documented in the changelog for the next game version

@MrRowey
Base SCU Changes
26ef47e 
- HP Reduction
- Build rate Reduction
- Base Gun Damage Reduction
- Gun Damage Reduction move to upgrades
@MrRowey MrRowey added the area: balance related to units balance label Apr 17, 2024
@MrRowey MrRowey added the DO NOT MERGE Don't Merge until removed label Apr 19, 2024
lL1l1
lL1l1 reviewed Apr 20, 2024
View reviewed changes
units/XSL0301/XSL0301_unit.bp Outdated Show resolved Hide resolved
units/UAL0301/UAL0301_unit.bp Outdated Show resolved Hide resolved
units/UEL0301/UEL0301_unit.bp Outdated Show resolved Hide resolved
units/XSL0301/XSL0301_script.lua Outdated Show resolved Hide resolved
units/URL0301/URL0301_unit.bp Outdated Show resolved Hide resolved
units/UEL0301/UEL0301_script.lua Outdated Show resolved Hide resolved
units/UEL0301/UEL0301_unit.bp Outdated Show resolved Hide resolved
@MrRowey
Update Small Typos
62483b4
@MrRowey
Merge branch 'deploy/fafdevelop' into Base-SCU-Rework
09f5dea
@MrRowey
Sera Base dame ehnacement swap
ae7d1b3 
Moved the damage that was took from the base gun to the sensor upgrade rather than the OC upgrade
@MrRowey MrRowey requested a review from lL1l1 April 26, 2024 19:13
@MrRowey MrRowey mentioned this pull request Apr 26, 2024
Open
lL1l1
lL1l1 reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@lL1l1 lL1l1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed scripts for damage mods. Added damage mod to shield upgrade for Seraphim SACU because it's necessary for the "Rambo" preset (OC/shield/nano).

@lL1l1
Copy link
Contributor

lL1l1 commented Apr 26, 2024

When you get the final stats, let me know so that I can change the unit descriptions for the upgrades, since they have the stats written in them manually.

@MrRowey MrRowey marked this pull request as draft April 28, 2024 15:54
MrRowey added 10 commits May 1, 2024 17:24
@MrRowey
Merge branch 'deploy/fafdevelop' into Base-SCU-Rework
7365acd
@MrRowey
Create balance.6092.md
01383cb
@MrRowey
Addtions
a78a99c 
- Order Enhancements
- Cybran Gets Stealth Field as base addition as a support feeater
- Remove of Stealth upgrade due to new stealth field
@MrRowey
Added Base UEF Chanages and Implementes Small Jamming Field. Includes…
eb321df 
… Script File Annotiaions
@MrRowey
Added Stealth Field to base Cybran. Updated UEF Wreckage Layers. Upda…
7099d58 
…ted Base Cost of Cybran SCU. Remove Stealth as Upgrade from BP & Script File. Removed Stealth Preset.
@MrRowey
Updated the new Regen Rate for the base Sera SCU & Annotated script f…
a884369 
…ile.
@MrRowey
Quantum Games HP Reduced by 50%, Build Cost Reduced by 15%
5d58c79
@MrRowey
Remove Transport Attachment from Qunatum Gates as it unused
75bb9e9
@MrRowey
Update Aeon SCU Cost, Improve Aeon Preset Order, Added TODO for Sera/…
8fcca7e 
…Aeon Passive Support Features.
@MrRowey
Add removed Damage from base guns to SCU Upgrades, Aeon SCU reduced B…
c1cdae1 
…ase Range to be same as other factions. Removed Eco Bonus from Sera SCU and Applied smaller RAS type bonus to Enegering
lL1l1
lL1l1 reviewed May 19, 2024
View reviewed changes
units/URL0301/URL0301_unit.bp Outdated Show resolved Hide resolved
units/URL0301/URL0301_unit.bp Outdated Show resolved Hide resolved
units/UEL0301/UEL0301_unit.bp
@@ -1,5 +1,5 @@
UnitBlueprint{
Description = "<LOC uel0301_desc>Support Armored Command Unit",
Description = "<LOC uel0301_desc>Support Command Unit",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names shouldn't be changed, everyone calls them SACU nowadays, and the presets are also named "SACU". The change here would have no effect anyway because the localization database isn't updated in your branch.

units/UAL0301/UAL0301_unit.bp Outdated
Comment on lines 199 to 201
SacrificeEnergyMult = 0.9,
SacrificeMassMult = 0.9,
SacrificeEnergyMult = 0.8,
SacrificeMassMult = 0.8,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of raw numbers, 0.9 -> 0.8 sacrifice efficiency is a much bigger downside than the 150 mass 2500 energy for the sacrifice upgrade. I think it's too early to nerf it this much just because it gets integrated into the base SACU, and it's better to see how the mechanic will get used since it's already rarely used so its hard to tell how good it can be.
If this is for consistency with engineers, why not just buff their sacrifice ability instead?

units/XSL0301/XSL0301_unit.bp
Copy link
Contributor

@lL1l1 lL1l1 May 19, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last 4 commits, you reverted a bunch of changes that you made to the Seraphim SACU.

@lL1l1
Copy link
Contributor

lL1l1 commented May 19, 2024

Also it's generally better to have smaller commits detailing single changes instead of a large commit consisting of multiple changes. You have commit titles with a 3 item list separated by commas; that could be split up.
It's a good idea to put the reasoning for a change in the commit description too, it will help write patch notes and show others your thoughts behind the changes.

@MrRowey
Copy link
Member Author

MrRowey commented May 19, 2024

Also it's generally better to have smaller commits detailing single changes instead of a large commit consisting of multiple changes. You have commit titles with a 3 item list separated by commas; that could be split up.
It's a good idea to put the reasoning for a change in the commit description too, it will help write patch notes and show others your thoughts behind the changes.

I will update the commit description when I'm done

lL1l1
lL1l1 reviewed May 20, 2024
View reviewed changes
units/UAL0301/UAL0301_unit.bp
Comment on lines -201 to -202
StorageEnergy = 500,
StorageMass = 275,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove storage from SACU?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opps Was checked out on the wrong branch was experimenting with things, ill revet that

@MrRowey MrRowey changed the title Base SCU Changes SCU Changes May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GodFuper GodFuper GodFuper left review comments

@lL1l1 lL1l1 lL1l1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: balance related to units balance DO NOT MERGE Don't Merge until removed
Projects
None yet
Milestone
Development iteration II of 2024
Development

Successfully merging this pull request may close these issues.

Balance idea: SCU Rebalance
3 participants
@MrRowey @lL1l1 @GodFuper