Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate creation of the changelog #6138

Merged
merged 17 commits into from
Apr 28, 2024

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Apr 27, 2024

Description of the proposed changes

Continuation of #6137

Updates the Github workflow file to create a changelog without the need to run the bash script on your system. The workflow removes the need to have a Bash interpreter available on your system. At the moment it outputs the following file:

changelog.md

Which is a great start!

Testing done on the proposed changes

Run the bash script locally and on Github via the workflow.

@Garanas
Copy link
Member Author

Garanas commented Apr 27, 2024

@Sheikah45 and/or @Brutus5000 would either of you be available to review the workflow file? In particular I do not fully understand why the script fails when it's not run in the faf-lua container. See also the failed runs.

@Sheikah45
Copy link
Member

Sheikah45 commented Apr 27, 2024

The workflow does run in the lua container though. It is specified in the container line of the yaml as part of this PR. From the log messages it just looks like the container does not have bash installed in it. Edit: Nevermind I see now that you are installing bash so suspect it is just the path to combine.sh being wrong

@Sheikah45
Copy link
Member

Also why are you specifying bash? Why not just execute the file and allow the shebang to tell the system how to execute it

@Sheikah45
Copy link
Member

Also you are calling combine.sh as if it is in the root directory but it looks like the file lives in changelog/snippets so just ./combine.sh will result in file not found

@Garanas
Copy link
Member Author

Garanas commented Apr 28, 2024

@Sheikah45 processed your feedback 👍

Also you are calling combine.sh as if it is in the root directory but it looks like the file lives in changelog/snippets so just ./combine.sh will result in file not found

Note the working directory that is set!

@Sheikah45
Copy link
Member

Ah yeah I had missed that

@Garanas Garanas changed the title Feature/changelog workflow Automate creation of the changelog Apr 28, 2024
@Garanas Garanas merged commit 6544985 into deploy/fafdevelop Apr 28, 2024
4 checks passed
@Garanas Garanas deleted the feature/changelog-workflow branch April 28, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants