-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate creation of the changelog #6138
Conversation
@Sheikah45 and/or @Brutus5000 would either of you be available to review the workflow file? In particular I do not fully understand why the script fails when it's not run in the faf-lua container. See also the failed runs. |
The workflow does run in the lua container though. It is specified in the container line of the yaml as part of this PR. |
Also why are you specifying bash? Why not just execute the file and allow the shebang to tell the system how to execute it |
Also you are calling combine.sh as if it is in the root directory but it looks like the file lives in changelog/snippets so just ./combine.sh will result in file not found |
@Sheikah45 processed your feedback 👍
Note the working directory that is set! |
Ah yeah I had missed that |
Description of the proposed changes
Continuation of #6137
Updates the Github workflow file to create a changelog without the need to run the bash script on your system. The workflow removes the need to have a Bash interpreter available on your system. At the moment it outputs the following file:
changelog.md
Which is a great start!
Testing done on the proposed changes
Run the bash script locally and on Github via the workflow.