Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the brain components #6267

Merged
merged 10 commits into from
Jun 18, 2024
Merged

Rework the brain components #6267

merged 10 commits into from
Jun 18, 2024

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Jun 17, 2024

The brain components are now in separate files. This allows you to hook the component before it is being applied to the standard brain class.

Testing done on the proposed changes

Start a scenario and observe that all the functionality (energy management, jammers, hqs, etc) are still functional.

Checklist

  • Changes are documented in the changelog for the next game version

@Garanas Garanas added the area: code style code refactoring label Jun 17, 2024
@Garanas
Copy link
Member Author

Garanas commented Jun 18, 2024

The internal HQs field of the brain was not referenced by any of the existing mods and is therefore safe to rename.

@Garanas
Copy link
Member Author

Garanas commented Jun 18, 2024

I won't touch the statistics module because of: #6129
And the same reasoning applies to the energy management module because of: #5822

@Garanas Garanas merged commit f80ab5d into develop Jun 18, 2024
3 checks passed
@Garanas Garanas deleted the refactor/brain-components branch June 18, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: code style code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant