Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Seraphim and Coalition maps #417

Merged
merged 18 commits into from
Mar 14, 2024
Merged

Update Seraphim and Coalition maps #417

merged 18 commits into from
Mar 14, 2024

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Aug 31, 2023

Fixes #356

Includes two new coalition maps:

  • Red Revenge
  • Rebel's Rest

And one new Seraphim map:

  • Overlord Surth Velsok

Copy link
Member

@speed2CZ speed2CZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • scenarios are missing map_version the server needs it to update the map correctly
  • building from mobile factories has to be updated

@@ -4,20 +4,35 @@ local ScenarioFramework = import('/lua/ScenarioFramework.lua')
local CustomFunctions = '/maps/FAF_Coop_Operation_Ioz_Shavoh_Kael/FAF_Coop_Operation_Ioz_Shavoh_Kael_CustomFunctions.lua'
local ScenarioPlatoonAI = import('/lua/ScenarioPlatoonAI.lua')
local ScenarioUtils = import('/lua/sim/ScenarioUtilities.lua')
local CustomFunctions = import('/maps/FAF_Coop_Operation_Thisl_Eniz/FAF_Coop_Operation_Thisl_Eniz_CustomFunctions.lua')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line has to be deleted

Configurations = {
['standard'] = {
teams = {
{ name = 'FFA', armies = {'Player1','Civilians','QAI','Player2','Player3','Player4',} },
},
customprops = {
},
factions = { {'uef', 'aeon', 'cybran'}, {'uef', 'aeon', 'cybran'}, {'uef', 'aeon', 'cybran'}, {'uef', 'aeon', 'cybran'} },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is intentional?

},
customprops = {
},
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing available factions?

},
customprops = {
},
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing available factions?

Copy link
Member

@speed2CZ speed2CZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@zqh9843
Copy link

zqh9843 commented Feb 27, 2024

Overlord Surth Velsok had a weird lighting bug the last time I played. But it's not consistent on every platform tho. Seems to affect AMD CPU+NVIDIA GPU combination the most.

@Garanas
Copy link
Member Author

Garanas commented Feb 27, 2024

That can be tackled in a separate pull request.

@Garanas Garanas merged commit b3f8c0b into master Mar 14, 2024
@Garanas Garanas deleted the update/maps-10 branch March 18, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operation Kael: Easy difficulty bug
3 participants