Skip to content

Commit

Permalink
fixes #41 migrate all integration test (or delete useless ones)
Browse files Browse the repository at this point in the history
  • Loading branch information
Brutus5000 committed Nov 1, 2017
1 parent 0128cb1 commit 45cca38
Show file tree
Hide file tree
Showing 19 changed files with 69 additions and 557 deletions.
52 changes: 52 additions & 0 deletions src/inttest/java/com/faforever/api/data/AvatarElideTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
package com.faforever.api.data;

import com.faforever.api.AbstractIntegrationTest;
import com.faforever.api.avatar.AvatarRepository;
import com.faforever.api.data.domain.Avatar;
import org.junit.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.test.context.jdbc.Sql;
import org.springframework.test.context.jdbc.Sql.ExecutionPhase;
import org.springframework.test.web.servlet.MvcResult;

import static org.hamcrest.Matchers.hasSize;
import static org.hamcrest.Matchers.is;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

@Sql(executionPhase = ExecutionPhase.BEFORE_TEST_METHOD, scripts = "classpath:sql/prepDefaultUser.sql")
@Sql(executionPhase = ExecutionPhase.BEFORE_TEST_METHOD, scripts = "classpath:sql/prepAvatarData.sql")
@Sql(executionPhase = ExecutionPhase.AFTER_TEST_METHOD, scripts = "classpath:sql/cleanAvatarData.sql")
public class AvatarElideTest extends AbstractIntegrationTest {
@Autowired
AvatarRepository avatarRepository;

@Test
public void getUnusedAvatar() throws Exception {
Avatar avatar = avatarRepository.findOne(1);

MvcResult result = mockMvc.perform(get("/data/avatar/1"))
.andExpect(status().isOk())
.andExpect(jsonPath("$.data.id", is(String.valueOf(avatar.getId()))))
.andExpect(jsonPath("$.data.type", is("avatar")))
.andExpect(jsonPath("$.data.attributes.tooltip", is(avatar.getTooltip())))
.andExpect(jsonPath("$.data.attributes.url", is(avatar.getUrl())))
.andExpect(jsonPath("$.data.relationships.assignments.data", hasSize(0)))
.andReturn();
}

@Test
public void getAvatarWithPlayer() throws Exception {
Avatar avatar = avatarRepository.findOne(2);

MvcResult result = mockMvc.perform(get("/data/avatar/2"))
.andExpect(status().isOk())
.andExpect(jsonPath("$.data.id", is(String.valueOf(avatar.getId()))))
.andExpect(jsonPath("$.data.type", is("avatar")))
.andExpect(jsonPath("$.data.attributes.tooltip", is(avatar.getTooltip())))
.andExpect(jsonPath("$.data.attributes.url", is(avatar.getUrl())))
.andExpect(jsonPath("$.data.relationships.assignments.data", hasSize(2)))
.andReturn();
}
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.faforever.api.clan;
package com.faforever.api.data;

import com.faforever.api.AbstractIntegrationTest;
import com.faforever.api.clan.ClanRepository;
import com.faforever.api.data.domain.Clan;
import com.faforever.api.data.domain.ClanMembership;
import com.faforever.api.data.domain.Player;
Expand Down
3 changes: 3 additions & 0 deletions src/inttest/resources/sql/cleanAvatarData.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
DELETE FROM avatars;
DELETE FROM avatars_list;

14 changes: 0 additions & 14 deletions src/inttest/resources/sql/createUsers.sql

This file was deleted.

10 changes: 10 additions & 0 deletions src/inttest/resources/sql/prepAvatarData.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
DELETE FROM avatars;
DELETE FROM avatars_list;

INSERT INTO avatars_list (id, url, tooltip) VALUES
(1, 'http://localhost/avatar1.png', 'Avatar No. 1'),
(2, 'http://localhost/avatar2.png', 'Avatar No. 2');

INSERT INTO avatars (id, idUser, idAvatar, selected) VALUES
(1, 1, 2, 1),
(2, 2, 2, 0);
16 changes: 0 additions & 16 deletions src/test/java/com/faforever/api/FafJavaApiApplicationTests.java

This file was deleted.

16 changes: 0 additions & 16 deletions src/test/java/com/faforever/api/TestUser.java

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.faforever.integration.factories;
package com.faforever.api.clan;

import com.faforever.api.data.domain.Clan;
import com.faforever.api.data.domain.Player;
Expand Down
1 change: 0 additions & 1 deletion src/test/java/com/faforever/api/clan/ClanServiceTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import com.faforever.api.player.PlayerRepository;
import com.faforever.api.player.PlayerService;
import com.faforever.api.security.JwtService;
import com.faforever.integration.factories.ClanFactory;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.junit.Before;
import org.junit.Rule;
Expand Down
102 changes: 0 additions & 102 deletions src/test/java/com/faforever/api/data/JsonApiAvatarIntegrationTest.java

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package com.faforever.api.data.listeners;

import com.faforever.api.clan.ClanFactory;
import com.faforever.api.config.FafApiProperties;
import com.faforever.api.data.domain.Clan;
import com.faforever.integration.factories.ClanFactory;
import org.junit.Before;
import org.junit.Test;

Expand Down
Loading

0 comments on commit 45cca38

Please sign in to comment.