Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement username/password change, password reset #35

Closed
micheljung opened this issue Feb 3, 2017 · 9 comments
Closed

Implement username/password change, password reset #35

micheljung opened this issue Feb 3, 2017 · 9 comments
Assignees
@Geosearchef
Labels
in progress
Milestone
v1.0

Comments

@micheljung
Copy link
Member

micheljung commented Feb 3, 2017 •
edited
Loading

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
Geosearchef added a commit that referenced this issue Apr 14, 2017
@Geosearchef
#35 implement change password
a7b6670
@Geosearchef
Copy link
Member

unit tests missing

@Geosearchef Geosearchef changed the title Implement password change Implement username/password change, password reset Apr 15, 2017
Geosearchef added a commit that referenced this issue Apr 15, 2017
@Geosearchef
#35 implement username change, password reset
83116b8
@micheljung micheljung modified the milestone: v1.0 Apr 21, 2017
@micheljung
Copy link
Member Author

Since the password is currently only sha256'd and might, therefore, be read and converted to plaintext by an attacker, we should encrypt the JWT payload

@Geosearchef
Copy link
Member

Geosearchef commented Apr 21, 2017 •
edited
Loading

not relevant for password reset, but for registration, registration may also be switched to entering username and password when claiming the token.

@IDragonfire
Copy link
Contributor

What is the state of this?

@Geosearchef
Copy link
Member

nearly complete, I will finish as soon as I get access to a computer I can test on (should be the next 2-3 days).

@IDragonfire
Copy link
Contributor

Do you need help with something?

PS.: #76 (comment)

Geosearchef added a commit that referenced this issue May 10, 2017
@Geosearchef
#35 switch reset identification to email
4217654
Geosearchef added a commit that referenced this issue May 10, 2017
@Geosearchef
#35 switch reset identification to email
4b4b6a3
Geosearchef added a commit that referenced this issue May 10, 2017
@Geosearchef
#35 unit tests
d8e140d
@Geosearchef
Copy link
Member

no, should be done, just hadn't got enough time, thx

Geosearchef added a commit that referenced this issue May 10, 2017
@Geosearchef
#35 implement change password
3e01701
Geosearchef added a commit that referenced this issue May 10, 2017
@Geosearchef
#35 implement username change, password reset
2d32218
Geosearchef added a commit that referenced this issue May 10, 2017
@Geosearchef
#35 switch reset identification to email
bf1d724
Geosearchef added a commit that referenced this issue May 10, 2017
@Geosearchef
#35 unit tests
aaf6dda
@coveralls coveralls mentioned this issue May 10, 2017
Merged
Brutus5000 pushed a commit that referenced this issue Oct 8, 2017
@Geosearchef @Brutus5000
#35 implement change password
43a9a74
Brutus5000 pushed a commit that referenced this issue Oct 8, 2017
@Geosearchef @Brutus5000
#35 implement username change, password reset
d6817e1
Brutus5000 pushed a commit that referenced this issue Oct 8, 2017
@Geosearchef @Brutus5000
#35 switch reset identification to email
45c0975
Brutus5000 pushed a commit that referenced this issue Oct 8, 2017
@Geosearchef @Brutus5000
#35 unit tests
31ce10e
Brutus5000 added a commit that referenced this issue Oct 8, 2017
@Brutus5000
#35 change token expiration to long + more user friendly instantiation
fc7977f
Brutus5000 added a commit that referenced this issue Oct 8, 2017
@Brutus5000
#35 check for password on password change
98dedd5 
rework tests (use builder, less strings in test)
Brutus5000 added a commit that referenced this issue Oct 8, 2017
@Brutus5000
#35 check for password on password change
722bf1a 
rework tests (use builder, less strings in test)
Brutus5000 added a commit that referenced this issue Oct 8, 2017
@Brutus5000
#35 check for password on password change
0525ccd 
rework tests (use builder, less strings in test)
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 return Optional<User> in UserRepository
11d2309
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 return Optional<User> in UserRepository
b8de43e
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 return Optional<User> in UserRepository
a42502e
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 return Optional<User> in UserRepository
041f6e1
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 update Anope IRC password on passwort change
6622bfd
Brutus5000 pushed a commit that referenced this issue Oct 18, 2017
@Geosearchef @Brutus5000
#35 implement change password
f0106a3
Brutus5000 pushed a commit that referenced this issue Oct 18, 2017
@Geosearchef @Brutus5000
#35 implement username change, password reset
0a7f37c
Brutus5000 pushed a commit that referenced this issue Oct 18, 2017
@Geosearchef @Brutus5000
#35 switch reset identification to email
d02c906
Brutus5000 pushed a commit that referenced this issue Oct 18, 2017
@Geosearchef @Brutus5000
#35 unit tests
acbff36
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 change token expiration to long + more user friendly instantiation
42fc49a
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 check for password on password change
84f6e4c 
rework tests (use builder, less strings in test)
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 save NameRecord on changing username
9865e23
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 reserve usernames after name change for 6 month
ef5980a
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 allow password reset by username OR email
d806f3a
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 return Optional<User> in UserRepository
f30fc53
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 update Anope IRC password on passwort change
032972e
Brutus5000 pushed a commit that referenced this issue Oct 18, 2017
@Geosearchef @Brutus5000
#35 implement change password
8807488
Brutus5000 pushed a commit that referenced this issue Oct 18, 2017
@Geosearchef @Brutus5000
#35 implement username change, password reset
6fafd73
Brutus5000 pushed a commit that referenced this issue Oct 18, 2017
@Geosearchef @Brutus5000
#35 switch reset identification to email
8d4f554
Brutus5000 pushed a commit that referenced this issue Oct 18, 2017
@Geosearchef @Brutus5000
#35 unit tests
d4b054c
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 change token expiration to long + more user friendly instantiation
32dbdbc
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 check for password on password change
2dc5ec7 
rework tests (use builder, less strings in test)
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 save NameRecord on changing username
63c6acc
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 reserve usernames after name change for 6 month
1b3130c
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 allow password reset by username OR email
94a1f64
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 return Optional<User> in UserRepository
2b1db42
Brutus5000 added a commit that referenced this issue Oct 18, 2017
@Brutus5000
#35 update Anope IRC password on passwort change
22c93d3
@Brutus5000
Copy link
Member

Finally :)

@micheljung
Copy link
Member Author

Hooray! :) Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geosearchef Geosearchef

Labels
in progress
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
4 participants
@IDragonfire @micheljung @Geosearchef @Brutus5000