filename filter maps #208
filename filter maps #208
Conversation
ghost
assigned 
1-alex98
force-pushed
the
feature/#207-filename-filter-maps
branch
4 times, most recently
from
67975d0
to
e75f15e
Compare
|
How do we go about it? |
|
Maybe you could use FileNameUtil. If you have windows environment you could run tests. @micheljung was complaining about test failing under windows. But it is working fine in linux env. Maybe regex can be tweaked to support both platforms' filenames |
|
Where should I use FileNameUtil? And which class of FileUtil, can not find any thing helping there |
|
Can you comment on lines ? |
1-alex98
force-pushed
the
feature/#207-filename-filter-maps
branch
from
e75f15e
to
c395468
Compare
|
The approach here is to just remove faulty characters here on upload |
| @@ -71,6 +71,8 @@ void uploadMap(byte[] mapData, String mapFilename, Player author, boolean isRank | |||
| Assert.notNull(author, "'author' must not be null"); | |||
| Assert.isTrue(mapData.length > 0, "'mapData' must not be empty"); | |||
|
|
|||
| mapFilename = mapFilename.replaceAll("[^\\w.\\-]", ""); //replacing all characters that are illegal in filenames | |||
There was a problem hiding this comment.
consider using FileNameUtil.normalizeFileName method
1-alex98
force-pushed
the
feature/#207-filename-filter-maps
branch
from
c395468
to
ea39852
Compare
|
I did |
|
Due to current cases on prod we not only need to check the file name but also remove all non-ascii characters from the map name itself. @axel1200 Could you add this here? |
|
Ehmm is that not what I was doing? |
1-alex98
force-pushed
the
feature/#207-filename-filter-maps
branch
from
ea39852
to
b5c59a8
Compare
|
@bukajsytlos I looked into the normalize file name method and it is pretty bad it replaces %| and some other character instead of replacing everything that is not a letter or an underscore. because I could imagine some additional characters that wont get replaced like this and would cause problems again... |
|
@axel1200 yeah I take a look at it too. The thing is that it should produce valid filenames from OS stand-point of view. If this does not meet business requirement for map names we could create new name transformation. Not sure which characters should be removed for backward compatibility |
|
tab for example should be removed |
|
for example today somebody uploaded map with : character in it and broke the vault |
|
Short update: I am currently working on improvements of this PR |
|
Do so |
Brutus5000
force-pushed
the
feature/#207-filename-filter-maps
branch
from
f2c68c2
to
d6a55ab
Compare
Brutus5000
force-pushed
the
feature/#207-filename-filter-maps
branch
from
d6a55ab
to
9da02aa
Compare
No description provided.