Fixes #249

[1-alex98]

No description provided.

[Brutus5000]

Instead of the two checks on getRevealWinner compare with votingSubject.getRevealWinner() == Boolean.FALSE

To be honest I have no clue what this is validating. What is a VotingSubjectRevealWinnerValidator actually validating? Your code is changing it's behavior, but it is untested and undocumented. I demand unit tests to verify the desired behavior.

[1-alex98]

I got 2 integration tests on this but bukajsytlos changed the logic in a way that was similar but not the same

[bukajsytlos]

But Brutus is right. I changed/broke the logic but tests still passed. So there is something missing on test side, right?

[1-alex98]

Well yes I did not test all cases, I tested the security relevant ones

[1-alex98]

I will add another test

outdated

[1-alex98]

Btw if you merge this could you deploy it as well?

[Brutus5000]

Probably not. Depends on required database migrations.

[1-alex98]

oh ok. hmm

[1-alex98]

👍 only needs to be deployed some when then ftx can do his ladder vote

[Brutus5000]

@axel1200 it's on prod now

[1-alex98]

Cool only missing the modor PR and I can tell ftx his ladder voting stuff is done