Closes #282 Allow login via username or email #283
Conversation
bukajsytlos
force-pushed
the
feature/282-login-via-email-username
branch
from
af613ea
to
80d49e4
Compare
| public UserDetails loadUserByUsername(String username) throws UsernameNotFoundException { | ||
| User user = userRepository.findOneByLoginIgnoreCase(username) | ||
| .orElseThrow(() -> new UsernameNotFoundException("User could not be found: " + username)); | ||
| public UserDetails loadUserByUsername(String usernameOrEmail) throws UsernameNotFoundException { |
There was a problem hiding this comment.
Dont we still have accounts that have same email and username if compared to lowwer case how would that affect this code
There was a problem hiding this comment.
well good question, but I would argue that emails should be CI and username was searched CI even before. So if there are two accounts with same email, they will fail to log. Let's hope they will contact mod :)
There was a problem hiding this comment.
Ha interesting point: this is also an issue on password reset.
But I have checked, hibernate does not throw an exception.
Two email accounts per user are not wanted, so we will ban of the two users and then need to scrap their email address I guess.
Otherwise: if you have this issue, then just use your login name. All other cases are the user's own fault.
Closes #282 Allow login via username or email