Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#327 Exe uploads #328

Merged
merged 12 commits into from
Sep 24, 2019
Merged

#327 Exe uploads #328

merged 12 commits into from
Sep 24, 2019

Conversation

norraxx
Copy link

@norraxx norraxx commented Aug 5, 2019

Don't merge, just for review purposes

Brutus5000
Brutus5000 requested changes Aug 5, 2019
View reviewed changes
Copy link
Member

@Brutus5000 Brutus5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some first glimpse comments

src/main/java/com/faforever/api/deployment/LegacyFeaturedModDeploymentTask.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/api/config/FafApiProperties.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/api/config/FafApiProperties.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/api/deployment/ExeUploaderController.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/api/deployment/ExeUploaderController.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/api/deployment/ExeUploaderService.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/api/featuredmods/LegacyFeaturedModFileRepository.java Outdated Show resolved Hide resolved
@norraxx norraxx changed the title #327 wip #327 Exe uploads Aug 10, 2019
@norraxx norraxx force-pushed the feature/#327-uploads branch 3 times, most recently from 737e5da to 47732bb Compare August 25, 2019 02:50
@norraxx norraxx force-pushed the feature/#327-uploads branch 2 times, most recently from fa90efb to 47732bb Compare August 25, 2019 20:11
@norraxx norraxx mentioned this pull request Sep 1, 2019
Merged
1-alex98
1-alex98 previously approved these changes Sep 3, 2019
View reviewed changes
Brutus5000
Brutus5000 requested changes Sep 5, 2019
View reviewed changes
src/inttest/resources/sql/cleanFeaturedMods.sql Outdated Show resolved Hide resolved
src/inttest/resources/sql/prepFeaturedMods.sql Outdated Show resolved Hide resolved
src/inttest/resources/sql/prepFeaturedMods.sql Show resolved Hide resolved
src/main/java/com/faforever/api/deployment/ExeUploaderController.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/api/deployment/ExeUploaderService.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/api/featuredmods/LegacyFeaturedModFileRepository.java Show resolved Hide resolved
src/test/java/com/faforever/api/deployment/ExeUploaderControllerTest.java Show resolved Hide resolved
src/test/java/com/faforever/api/deployment/ExeUploaderServiceTest.java Show resolved Hide resolved
norraxx pushed a commit to norraxx/db that referenced this pull request Sep 8, 2019
That migrations are needed for FAForever/faf-java-api#328
a3de0c6
Brutus5000 pushed a commit to FAForever/db that referenced this pull request Sep 8, 2019
@Brutus5000
That migrations are needed for FAForever/faf-java-api#328
a6e412f
@norraxx norraxx force-pushed the feature/#327-uploads branch 2 times, most recently from d54842c to 2fe87f9 Compare September 21, 2019 16:31
Brutus5000
Brutus5000 requested changes Sep 21, 2019
View reviewed changes
src/main/java/com/faforever/api/deployment/ExeUploaderService.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/api/deployment/ExeUploaderService.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/api/featuredmods/LegacyFeaturedModFileRepository.java Outdated Show resolved Hide resolved
src/test/java/com/faforever/api/deployment/ExeUploaderControllerTest.java Outdated Show resolved Hide resolved
src/test/java/com/faforever/api/deployment/ExeUploaderControllerTest.java Outdated Show resolved Hide resolved
src/test/java/com/faforever/api/deployment/ExeUploaderServiceTest.java Outdated Show resolved Hide resolved
src/test/java/com/faforever/api/deployment/ExeUploaderServiceTest.java Outdated Show resolved Hide resolved
@Brutus5000 Brutus5000 merged commit 545a0b8 into FAForever:develop Sep 24, 2019
@norraxx norraxx mentioned this pull request Sep 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brutus5000 Brutus5000 Brutus5000 approved these changes

@1-alex98 1-alex98 1-alex98 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@norraxx @Brutus5000 @1-alex98