Map upload refactor + validation #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brutus5000
force-pushed
the
feature/map-upload-refactor
branch
3 times, most recently
from
77135ea
to
ed56a47
Compare
Brutus5000
force-pushed
the
feature/map-upload-refactor
branch
2 times, most recently
from
5573ac3
to
9cb2657
Compare
Brutus5000
force-pushed
the
feature/map-upload-refactor
branch
from
9cb2657
to
4e05cc7
Compare
1-alex98
reviewed
Sep 1, 2019
| useJUnitPlatform { | ||
| } | ||
| testLogging { | ||
| events("passed", "skipped", "failed") |
There was a problem hiding this comment.
Would that also be interesting for the client?
# Conflicts: # src/test/java/com/faforever/api/user/UserServiceTest.java
1-alex98
previously approved these changes
Sep 7, 2019
Brutus5000
force-pushed
the
feature/map-upload-refactor
branch
from
bf0fe7a
to
ec4913a
Compare
1-alex98
reviewed
Sep 12, 2019
| color: darkred; | ||
| } | ||
| </style> | ||
| <link href="https://fonts.googleapis.com/css?family=Yanone+Kaffeesatz" rel="stylesheet" type="text/css"/> |
1-alex98
previously approved these changes
Sep 12, 2019
|
@axel1200 You should really test out the stuff you approve. Then you would have noticed that the css is not declared as accessible resource and that it is broken. (I'm working on it) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.