Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#348 cleanup if Spring components #350

Merged
merged 3 commits into from
Oct 3, 2019
Merged

#348 cleanup if Spring components #350

merged 3 commits into from
Oct 3, 2019

Conversation

marcoebbinghaus
Copy link
Contributor

I did everything that was mentioned for that issue. The classes that still have an @Inject annotation can't be replaced trivially.

Copy link
Member

@Brutus5000 Brutus5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why / where you think replacing the constructor with @RequiredArgsConstructor is not possible?
As far as I can see the classes

  • ClanService
  • AchievementService
  • ClansController
  • FeaturedModEnricher
    do not do anything special in the constructor, so it should work here.

- replaced constructor from AchievementService with lombok annotation.
- replaced constructor from ClanService with lombok annotation and aligned test.
@marcoebbinghaus
Copy link
Contributor Author

AchievementService: I think I just missed to replace the constructor here, sorry for that.
ClanService: The ClanServiceTest made usage of the constructor. But I removed the constructor and aligned the test now so it works without the constructor.
ClansController: I did replace the constructor here, what exactly do you miss?
FeaturedModEnricher: FeaturedModEnricher does not have a constructor and it only has a static field. I think Lombok annotations do not work with static fields ("All static fields will be skipped entirely (not considered for any of the generated methods, and no setter/getter will be made for them)." from https://projectlombok.org/features/Data).

I pushed the according changes.

@Brutus5000 Brutus5000 merged commit 2c7853d into FAForever:develop Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants