Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use primitive type for returningPlayer #583

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

BlackYps
Copy link
Contributor

@BlackYps BlackYps commented Apr 7, 2022

returningPlayer is not nullable in the database

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #583 (8b1118b) into develop (b458508) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #583   +/-   ##
==========================================
  Coverage      75.85%   75.85%           
  Complexity      1141     1141           
==========================================
  Files            239      239           
  Lines           3612     3612           
  Branches         231      231           
==========================================
  Hits            2740     2740           
  Misses           776      776           
  Partials          96       96           
Impacted Files Coverage Δ
...faforever/api/league/domain/LeagueSeasonScore.java 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b458508...8b1118b. Read the comment docs.

@Brutus5000 Brutus5000 merged commit 8ae7a77 into FAForever:develop Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants