Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow API access to Elide for services without user authentication #802

Merged
merged 2 commits into from Nov 28, 2023

Conversation

bukajsytlos
Copy link
Member

Closes #793 Allow API access to Elide for services without user authentication

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #802 (9f50171) into develop (ee3e472) will decrease coverage by 0.10%.
The diff coverage is 73.19%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #802      +/-   ##
=============================================
- Coverage      78.28%   78.18%   -0.10%     
- Complexity      1248     1254       +6     
=============================================
  Files            242      244       +2     
  Lines           3776     3805      +29     
  Branches         241      241              
=============================================
+ Hits            2956     2975      +19     
- Misses           715      724       +9     
- Partials         105      106       +1     
Files Coverage Δ
...in/java/com/faforever/api/data/DataController.java 73.91% <100.00%> (ø)
...ver/api/data/checks/IsClanMembershipDeletable.java 85.71% <100.00%> (ø)
...a/com/faforever/api/data/checks/IsEntityOwner.java 60.00% <100.00%> (ø)
...faforever/api/data/checks/IsEntityOwnerFilter.java 85.71% <100.00%> (ø)
...com/faforever/api/data/domain/GroupPermission.java 80.00% <ø> (ø)
...com/faforever/api/data/hook/BanInfoCreateHook.java 100.00% <100.00%> (ø)
...r/api/data/hook/BanInfoRevokeAuthorUpdateHook.java 100.00% <100.00%> (ø)
.../faforever/api/data/hook/ModerationReportHook.java 92.30% <100.00%> (ø)
...ain/java/com/faforever/api/security/ElideUser.java 70.00% <100.00%> (+12.85%) ⬆️
...faforever/api/security/FafAuthenticationToken.java 78.57% <ø> (-5.64%) ⬇️
... and 10 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee3e472...9f50171. Read the comment docs.

@bukajsytlos
Copy link
Member Author

will try to add some tests

@Brutus5000 Brutus5000 merged commit ff599fd into develop Nov 28, 2023
4 of 6 checks passed
@Brutus5000 Brutus5000 deleted the faf-java-api-793 branch November 28, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow API access to Elide for services without user authentication
3 participants