Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching of avatar images #34

Closed
Brutus5000 opened this issue Dec 27, 2017 · 4 comments
Closed

Caching of avatar images #34

Brutus5000 opened this issue Dec 27, 2017 · 4 comments

Comments

@Brutus5000
Copy link
Member

Right now, scrolling through an avatar list invokes a reload of all visible avatar images. This is invoncenient especially on small bandwithed connections.

@basalt79
Copy link
Contributor

hi, i have currently a look on this item.
can anyone give me a raff estimate of the amount of items in the avatar images?
a possible solution can be a cache used at UrlImageViewTableCell with key=url of the avatar.

whats your oppinion on this?

@Brutus5000
Copy link
Member Author

Brutus5000 commented Oct 18, 2018

Hi @basalt79 ,
we have ~250 avatar images. All images so far are 40x20 pixel PNG with ~3kb.

In theory it is possible that the image behind the url changes even though it's probably pretty rar. In this case the updateTime of the AvatarFX instances changes.

I am totally unfamiliar with JavaFX caching, so I'm open for all solutions.

@basalt79
Copy link
Contributor

hi @Brutus5000 , thx for the information. i will have a look on this.

Brutus5000 pushed a commit that referenced this issue Oct 22, 2018
@Brutus5000
Copy link
Member Author

fixed by 0eb0550

@Brutus5000 Brutus5000 added this to the 0.5.1 milestone Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants