Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#184 fix for small displays. #185

Merged
merged 2 commits into from Nov 13, 2023

Conversation

fcaps
Copy link
Contributor

@fcaps fcaps commented Nov 3, 2023

Tested in the latest chrome/FF/Edge on Windows.
Closes #184
faf-background

Comment on lines 29 to 30
setHeightFull()
setWidthFull()
isPadding = false
isSpacing = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just have it extend CompactVerticalLayout instead of VerticalLayout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't notice we already had custom base layouts for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow it's not working with the CompactVerticalLayout, not a kotlin-dev, so would be nice if you could tell me what's going on here.
is the init of the parent not called, or set to the wrong layout?

Copy link
Member

@Sheikah45 Sheikah45 Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The no-arg constructor of the super class and all init blocks should be called whenever the child object is created.

Is the object still having the padding and spacing classes applied when you run it locally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah.. thought it was some local cache, but it seams to have some other origin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got a new hint, spacing is gone, but padding is applied. i'll debug and look where this comes from

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sheikah45 local issue, it works.
did somehow change the content of CompactVerticalLayout, but was not aware of it.

@fcaps fcaps requested a review from Sheikah45 November 13, 2023 01:16
@Sheikah45 Sheikah45 merged commit 5031067 into FAForever:master Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth View - scroll window not working
2 participants