New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#184 fix for small displays. #185
Conversation
setHeightFull() | ||
setWidthFull() | ||
isPadding = false | ||
isSpacing = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just have it extend CompactVerticalLayout instead of VerticalLayout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't notice we already had custom base layouts for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
somehow it's not working with the CompactVerticalLayout, not a kotlin-dev, so would be nice if you could tell me what's going on here.
is the init of the parent not called, or set to the wrong layout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The no-arg constructor of the super class and all init blocks should be called whenever the child object is created.
Is the object still having the padding and spacing classes applied when you run it locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah.. thought it was some local cache, but it seams to have some other origin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got a new hint, spacing is gone, but padding is applied. i'll debug and look where this comes from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sheikah45 local issue, it works.
did somehow change the content of CompactVerticalLayout, but was not aware of it.
Tested in the latest chrome/FF/Edge on Windows.
Closes #184