Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line parameters to allow/block interfaces and/or ip addresses #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BenKluwe
Copy link

@BenKluwe BenKluwe commented Oct 7, 2019

No description provided.

@Geosearchef
Copy link
Member

How do you want to detect the interfaces to block? The ice adapter is not supposed to just use interfaces connected to the internet. It should also connect via local network, actually, it should work without the internet at all running a local FAF server.

@BenKluwe
Copy link
Author

BenKluwe commented Oct 8, 2019

The interfaces to allow and block are user defined (See FAForever/downlords-faf-client#1461), they need to be trickled through from the FAF client. This just exposes the ice4j harvester configuration (https://github.com/jitsi/ice4j/blob/e854e4efaf5dbb82e45028fceafe9d76ca93cb2a/doc/configuration.md) options to the command line. Even if an interface is bound, local connections are be able to be found because this is a routing problem for the OS and ICE to handle. As an example if a program is bound to ipv4 192.168.x.x and a connection attempt is made to 127.0.0.1 or 192.168.x.y, then the request still gets through to the other end.

@BenKluwe BenKluwe changed the title Resolves #23 Add command line parameters to allow/block interfaces and/or ip addresses Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants