Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique id handling code does not handle malformed UIDs very well #302

Closed
Wesmania opened this issue Jun 6, 2017 · 1 comment
Closed

Unique id handling code does not handle malformed UIDs very well #302

Wesmania opened this issue Jun 6, 2017 · 1 comment
Assignees
@Wesmania
Labels
in progress

Comments

@Wesmania
Copy link

Wesmania commented Jun 6, 2017

Right now the function decodeUniqueId that validates the encoded UID logs an exception and implicitly returns None when something fails. This causes the validate_unique_id function to try and assign None to a pair of values, which causes and exception.

We should explicitly return None after an exception in decodeUniqueId and detect and handle it in validate_unique_id.
Wesmania pushed a commit to Wesmania/server that referenced this issue Jun 6, 2017
Explicitly handle malformed encoded UIDs
bb550ca 
Fixes FAForever#302.

Signed-off-by: Igor Kotrasinski <i.kotrasinsk@gmail.com>
@Wesmania Wesmania mentioned this issue Jun 6, 2017
Closed
Wesmania pushed a commit to Wesmania/server that referenced this issue Jun 6, 2017
Explicitly handle malformed encoded UIDs
d2cf92f 
Fixes FAForever#302.

Signed-off-by: Igor Kotrasinski <i.kotrasinsk@gmail.com>
@Wesmania
Copy link
Author

Wesmania commented Dec 9, 2018

Obsolete.

@Wesmania Wesmania closed this as completed Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wesmania Wesmania

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wesmania @faf-bot