Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add host time for games sent from server with game info #333

Closed
GrotheFAF opened this issue Jan 3, 2018 · 5 comments · Fixed by #986
Closed

add host time for games sent from server with game info #333

GrotheFAF opened this issue Jan 3, 2018 · 5 comments · Fixed by #986
Labels
enhancement good first issue

Comments

@GrotheFAF
Copy link

I think it would be usefull information to see how old a hosted game is.
@0x647262
Copy link
Contributor

@Askaholic you can assign this one to me

@Askaholic
Copy link
Collaborator

Sure. It would also need to be added in the client too. Not sure how much people care about it since there hasn't been any discussion on the issue. Maybe @axel1200 or @micheljung have an opinion on this?

When you send the start time send it as an ISO formatted datetime just like the queue pop time in matchmaker_info.

@1-alex98
Copy link
Member

Well can not hurt to put it in the server message right

@KaukaHan
Copy link
Contributor

KaukaHan commented Mar 9, 2022

I can add this if needed. Might such information be usefull to determine average lobbysim time ?

@Askaholic
Copy link
Collaborator

Not sure why I added 'requires client changes' label, since the it doesn't have to be implemented in the client to add it here. I agree with @1-alex98, I don't see a reason to not add it since the client can just ignore it if it wants to.

@KaukaHan KaukaHan mentioned this issue Mar 12, 2022
Closed
KaukaHan added a commit to KaukaHan/server that referenced this issue Mar 17, 2022
@KaukaHan
Merge branch 'FAForever:develop' into issue/FAForever#333
56a2e2e
KaukaHan added a commit to KaukaHan/server that referenced this issue Mar 18, 2022
@KaukaHan
Merge branch 'issue/FAForever#333' of https://www.github.com/KaukaHan…
b0fba54 
…/server into issue/FAForever#333
@Askaholic Askaholic mentioned this issue Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add hosted_at field to game_info message Askaholic/server
5 participants
@0x647262 @Askaholic @GrotheFAF @1-alex98 @KaukaHan