Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to equilibrium #744

Closed
Askaholic opened this issue Mar 7, 2021 · 4 comments · Fixed by #764
Closed

Remove references to equilibrium #744

Askaholic opened this issue Mar 7, 2021 · 4 comments · Fixed by #764
Assignees

Comments

@Askaholic
Copy link
Collaborator

Askaholic commented Mar 7, 2021

Equilibrium was removed as a featured mod since it stopped being developed. We should remove all hardcoded references to it, there aren't very many.

We should also refactor this:

if not game_class:
game_class = {
FeaturedModType.LADDER_1V1: LadderGame,
FeaturedModType.COOP: CoopGame,
FeaturedModType.FAF: CustomGame,
FeaturedModType.FAFBETA: CustomGame,
FeaturedModType.EQUILIBRIUM: CustomGame
}.get(game_mode, Game)

I think it would be best to get rid of the automatic game class detection and pass in the desired class when creating a game.

@IanNaughton
Copy link
Contributor

Howdy, I'd like to lend a hand with this issue

@Askaholic
Copy link
Collaborator Author

Hi, sounds great! Are you up for taking a stab at removing the game class detection from that function too?

@IanNaughton
Copy link
Contributor

Isn't the class detection needed to support the create game calls from the lobbyconnection class (command_game_host function)? If the game class detection is removed from the create_game function, it looks like it would just move up the call stack to command_game_host. Am I understanding that correctly?

@Askaholic
Copy link
Collaborator Author

Yep that’s correct, but there just needs to be one case for coop games. Everything else that’s created through game_host should be a custom game.

There has been some discussion about supporting coop games using different featured mods e.g. nomads, in which case we would need a different way of deciding when to use the CoopGame class. That’s why I think it’s better to make that decision in game_host as the game service may not have enough information to be able to decide what is correct. For now we’ll keep checking the featured mod.

Askaholic pushed a commit that referenced this issue Apr 6, 2021
* Removed references to the equilibrium game mode, and migrated game class detection up the call stack out of game_service.py

* Fixing a failing test, and cleaning up some messy formatting

* Added CustomGame as a default game_class type argument for create_game. Also simplified class detection in lobbyconnection.py.

* Cleaning up a couple unused imports--oops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants