Game list sent on login sends all games, not just visible ones

[Askaholic]

Problem

When a player logs in they are sent a list of all open games here:

server/server/lobbyconnection.py

Lines 229 to 233 in 4dd4c92

	async def send_game_list(self):
	await self.send({
	"command": "game_info",
	"games": [game.to_dict() for game in self.game_service.open_games]
	})

However, there are certain visibility rules that are followed in consequent broadcasted game updates here:

server/server/__init__.py

Lines 174 to 180 in 4dd4c92

	self.write_broadcast(
	message,
	lambda conn: (
	conn.authenticated
	and game.is_visible_to_player(conn.player)
	)
	)

This causes 2 problems:

1. When a player logs in they can see friend only games for people who don't have them as friends, and they can see games of people who have foed them.
2. They will not receive any updates about those games causing them to appear as "ghost lobbies" that never go away.

Solution

Fixing it should be as simple as adding a filter condition that calls is_visible_to_player to the list comprehension in send_game_list.

Tests

We should add at least the following tests:

1. A test in tests/integration_tests/test_server.py that verifies that players can't see foes games and can't see games outside of their rating range when logging in.
2. A test in tests/integration_tests/test_matchmaker.py that verifies that players can still launch matchmaker games against foes.
3. A test in tests/unit_tests/test_lobbyconnection.py that verifies the behavior of send_game_list.