Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send player update when player disconnects #786

Closed
Askaholic opened this issue May 3, 2021 · 0 comments · Fixed by #832
Closed

Send player update when player disconnects #786

Askaholic opened this issue May 3, 2021 · 0 comments · Fixed by #832
Labels
enhancement

Comments

@Askaholic
Copy link
Collaborator

Right now there is no way to tell when a user disconnects. The client relies on the IRC server to get this information which is not great.

Probably the simplest way to do this would be to add some sort of state field to the existing player_info message that can signal when the player is logging out, and then simply mark player objects as dirty on logout.
@Askaholic Askaholic mentioned this issue Sep 6, 2021
Merged
@Askaholic Askaholic mentioned this issue Oct 1, 2021
Open
Askaholic added a commit that referenced this issue Dec 27, 2023
@Askaholic
Issue/#786 send player update on disconnect (#832)
d0152da 
* Add player state to player_info message and send update on disconnect

* Assert state is not None

* Only use offline state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue/#786 send player update on disconnect Askaholic/server
1 participant
@Askaholic