Issue/#660 Rare mysql deadlock #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may or may not be fixed magically with the move to MariaDB |
Askaholic
force-pushed
the
issue/#660-mysql-deadlock
branch
from
6ce2db1
to
b2fd4e5
Compare
cleborys
approved these changes
Feb 21, 2021
| try: | ||
| return await conn.execute(*args) | ||
| except OperationalError as e: | ||
| if any(msg in e.message for msg in ( |
There was a problem hiding this comment.
Nit: I think
Suggested change
| if any(msg in e.message for msg in ( | |
| if "Deadlock found" in e.message or "Lock wait timeout exceeded" in e.message: |
is maybe less elegant but a bit easier to read, unless you expect that more strings will be added to the list of checks.
Askaholic
force-pushed
the
issue/#660-mysql-deadlock
branch
from
b2fd4e5
to
afa0ca3
Compare
Askaholic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't really test it since it only happens rarely on production and probably only under high load.
Closes #660