Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/#482 improve documentation #753

Merged

Conversation

Askaholic
Copy link
Collaborator

@Askaholic Askaholic commented Mar 30, 2021

Not quite done with this.

  • Rewrite param docs to use markdown instead of rst
  • Add doctests to pytest
  • Remove server.abc

#482

@Askaholic Askaholic requested a review from cleborys March 30, 2021 00:15
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #753 (e67e2e4) into develop (e174f77) will increase coverage by 0.05%.
The diff coverage is 96.66%.

Impacted Files Coverage Δ
server/asyncio_extensions.py 100.00% <ø> (ø)
server/config.py 100.00% <ø> (ø)
server/configuration_service.py 100.00% <ø> (ø)
server/control.py 86.48% <ø> (ø)
server/core/__init__.py 100.00% <ø> (ø)
server/core/dependency_injector.py 100.00% <ø> (ø)
server/db/__init__.py 74.19% <ø> (ø)
server/factions.py 94.73% <ø> (ø)
server/game_service.py 99.01% <ø> (ø)
server/games/__init__.py 100.00% <ø> (ø)
... and 36 more

@Askaholic Askaholic force-pushed the issue/#482-improve-documentation branch from 1c777ee to 28fd37f Compare April 21, 2021 18:58
@Askaholic Askaholic force-pushed the issue/#482-improve-documentation branch from 28fd37f to e67e2e4 Compare April 23, 2021 18:52
@Askaholic Askaholic marked this pull request as ready for review April 23, 2021 19:03
@Askaholic
Copy link
Collaborator Author

Merging this because it makes some progress, but I don't see myself working on it further in the near future.

@Askaholic Askaholic merged commit ef0b308 into FAForever:develop Apr 23, 2021
@Askaholic Askaholic deleted the issue/#482-improve-documentation branch April 23, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant