Remove search boundaries #848
Conversation
Codecov Report
|
|
Btw there is a |
| boundaries = queue["boundary_80s"] | ||
|
|
||
| if queue["queue_name"] == "tmm2v2": | ||
| assert boundaries == [[300, 700]] |
There was a problem hiding this comment.
Maybe check the num_players here instead
| @@ -488,7 +488,7 @@ async def test_abort(mocker, lobbyconnection): | |||
| async def test_send_game_list(mocker, database, lobbyconnection, game_stats_service): | |||
| games = mocker.patch.object(lobbyconnection, "game_service") # type: GameService | |||
| game1, game2 = mock.create_autospec(Game(42, database, mock.Mock(), game_stats_service)), \ | |||
| mock.create_autospec(Game(22, database, mock.Mock(), game_stats_service)) | |||
There was a problem hiding this comment.
Is pre-commit doing this? I think gatsik’s formatting pr has the same stuff.
There was a problem hiding this comment.
Yes. I stopped running the pre-commit hooks, because flake8 failed because of the type hints server/matchmaker/matchmaker_queue.py:45:23: F821 undefined name 'GameService'. I still left the whitespace changes from the hook in because I wasn't sure which way it is supposed to be.
|
Please do not merge this, python client still uses it and will use it in the future for its ladder notifications. |
|
It won't be merged before v2.0. v2.0 will probably have some more breaking protocol changes, which will break python client functionality. |
|
Python client is currently ready for every single server's pull request to be merged and deployed today, except the match confirmation thing, but I guess it will be fixed in time. If something else will be added later to v2.0 changes, I think this would be fixed too |
|
Superseded by #816 |
I guess they were used by the python client for the "A person in your rating range is searching for a game. Click here to join them." message. However, the ranges are unreliable, because it just gives a hardcoded range and the trueskill quality also depends on the deviation. Also we alter the acceptable quality for every unsucessful queue pop. For team queues we use a different system entirely.
The java client doesn't use them for anything at the moment.