Fix docker build #955
Merged
Fix docker build #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow the correct version tag to be found even when the pip install command is run from a different directory.
Askaholic
force-pushed
the
fix-docker-build
branch
2 times, most recently
from
c913cdf
to
4321d78
Compare
Askaholic
force-pushed
the
fix-docker-build
branch
2 times, most recently
from
af5b613
to
3e850b8
Compare
Askaholic
force-pushed
the
fix-docker-build
branch
from
3e850b8
to
62e4773
Compare
Brutus5000
reviewed
Mar 10, 2023
There was a problem hiding this comment.
I think you need to create the user earlier (or use an id) and chown on copy. This is an example from a quarkus skeleton app:
FROM registry.access.redhat.com/ubi8/openjdk-17:1.14
ENV LANGUAGE='en_US:en'
# We make four distinct layers so if there are application changes the library layers can be re-used
COPY --chown=185 build/quarkus-app/lib/ /deployments/lib/
COPY --chown=185 build/quarkus-app/*.jar /deployments/
COPY --chown=185 build/quarkus-app/app/ /deployments/app/
COPY --chown=185 build/quarkus-app/quarkus/ /deployments/quarkus/
EXPOSE 8080
USER 185
ENV JAVA_OPTS="-Dquarkus.http.host=0.0.0.0 -Djava.util.logging.manager=org.jboss.logmanager.LogManager"
ENV JAVA_APP_JAR="/deployments/quarkus-run.jar"
|
I don’t think so. The python files are just installed to the system anyway. The user isn’t needed at all during the build process, it just exists for the container to use at run time. |
|
So "other" users have read/execute permissions on the code directory? |
|
Yes, the code is installed as a python package with pip. Just like if you were to system install any other dependency with pip. |
|
Tested on the test server and it still works with the existing configuration. |
Askaholic
force-pushed
the
fix-docker-build
branch
from
768e448
to
2254ed8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like some change in setuptools broke our docker build, however, this really just exposed a bug in our build where the
.gitdirectory was not being copied to the docker context and therefore the git version tag couldn't be found from thesetup.pyfile. I went ahead and rewrote the dockerfile to use a multi-stage approach so we should no longer have build tools likegitandpipenvinstalled in the final container.Closes #953