Additional linting actions #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Askaholic
force-pushed
the
additional-linting-actions
branch
from
8b955fa
to
8199a86
Compare
Askaholic
force-pushed
the
additional-linting-actions
branch
2 times, most recently
from
a07e291
to
6bc7d52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds flake8 to our github actions checks so we can add it as a requirement for merging. This also adds the
flake8-quotesplugin to make sure we're using double quotes everywhere. Since we requoted the whole codebase it seems that a few single quotes have snuck their way in because we had no automated checker.Unfortunately there are still a number of error codes that we are ignoring that would be nice to fix, but are mostly due to legacy code so I don't feel like fixing them in this PR.