Issue/#995 Improve player state tracking #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Askaholic
force-pushed
the
issue/#995-player-state-tracking
branch
from
e91cadc
to
a080c77
Compare
Askaholic
force-pushed
the
issue/#995-player-state-tracking
branch
from
a080c77
to
2633b9b
Compare
We need to protect against double game_host/join messages which means we need to establish a time window after a game_launch message is sent during which we are waiting to see that the game has opened and don't let the client do any other game related actions. This also means we need to clean up the GameConnection objects which would previously stick around forever if a client never responded to a game_launch message.
Askaholic
force-pushed
the
issue/#995-player-state-tracking
branch
from
2633b9b
to
c1145b8
Compare
Askaholic
force-pushed
the
issue/#995-player-state-tracking
branch
from
c1145b8
to
40a51ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state tracking was pretty messed up by the fact that the
HOSTINGandJOININGstates don't get set until the game sends back GPGNet messages, so clients could do agame_hostand then before their game was opened they could join a matchmaker queue. Once their game opened their player state would be set toHOSTINGand any matches that they got would be stuck in the queue until they manually stopped searching because the matchmaker would refuse to launch matches when one of the players had a state other thanSEARCHING_LADDER. Even if they closed their game instance, the player state would then be set toIDLEwhich still would not allow matches to launch.This also makes an adjustment to how players are considered to be in a game. Now, if players disconnect from the lobby server without sending a
GameState: Idlecommand they will still be considered part of the lobby. This is closer to how the behavior used to be except when someone does leave the game through the 'happy path' by closing their game, they should be completely removed from the internal state and consequently only be re-added when the host sends a newPlayerOptionfor them. This hopefully will reduce some of the issues that people have reported with there being more people in the lobby when they connect than it says in the client view.Related to #995
We won't mark it as closing since we should deploy these changes first and watch the logs to see if the issue has actually been solved. There may be other ways still in which the state tracking can go awry.