Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of github-api #418

Closed
Sheikah45 opened this issue Jan 3, 2023 · 0 comments · Fixed by #460
Closed

Remove usage of github-api #418

Sheikah45 opened this issue Jan 3, 2023 · 0 comments · Fixed by #460

Comments

@Sheikah45
Copy link
Member

Github API has a bug in it's _request functionality which makes it impossible to catch some kinds of errors in the returned promise of Repository.getRelease call. In our case we could not catch the error thrown when the github api returned a 403 due to rate limiting. This then can prevent start up of the application.

Due to this we should remove usage of github-api as the underlying issue has not been resolved. see github-tools/github#439.
fcaps added a commit to fcaps/website that referenced this issue Nov 12, 2023
@fcaps
move github link to the browser, so server-startup will not fail due …
926ddea 
…a rate-limit of the github-api FAForever#418
@fcaps fcaps mentioned this issue Nov 12, 2023
Merged
Sheikah45 pushed a commit that referenced this issue Nov 13, 2023
@fcaps
Move clientRelease url generator (#460)
06a76f8 
* move github link to the browser, so server-startup will not fail due a rate-limit of the github-api #418

* directly go to latest client release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move clientRelease url generator fcaps/website
1 participant
@Sheikah45