Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lobby_api querying #461

Merged
merged 1 commit into from
Nov 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ HOST=http://localhost:3000
API_URL=https://api.test.faforever.com
OAUTH_URL=https://hydra.test.faforever.com
WP_URL=https://direct.faforever.com
LOBBY_API_URL=http://lobby.faforever.com:4000
CALLBACK=auth
OAUTH_CLIENT_ID=faf-website
OAUTH_CLIENT_SECRET=banana
Expand Down
2 changes: 0 additions & 2 deletions .env.faf-stack
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ OAUTH_PUBLIC_URL=http://localhost:4444
# unsing the "production" wordpress because the faf-local-stack is just an empty instance without any news etc.
WP_URL=https://direct.faforever.com

LOBBY_API_URL=http://faf-python-server:4000

OAUTH_CLIENT_ID=faf-website
OAUTH_CLIENT_SECRET=banana
SESSION_SECRET_KEY=banana
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Local requirements:
- docker
- docker compose

The website has dependencies to Hydra, [Lobby](https://github.com/FAForever/server), Wordpress and the [Java-API](https://github.com/FAForever/faf-java-api).
The website has dependencies to Hydra, Wordpress and the [Java-API](https://github.com/FAForever/faf-java-api).
You can run those with the [local-stack](https://github.com/FAForever/faf-stack).

If you got the [local-stack](https://github.com/FAForever/faf-stack) up and running, we need to stop the "faf-website" and replace it with a development container.
Expand Down
1 change: 0 additions & 1 deletion express.js
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ app.get('/account/connect', loggedIn, require(routes + 'account/get/connectSteam
//app.get('/account/connectSteam', loggedIn, require(routes + 'account/get/connectSteam'));
app.get('/account/resync', loggedIn, require(routes + 'account/get/resync'));
// Not Protected
app.get('/lobby_api', cors(), require('./routes/lobby_api'));
app.get('/account/create', require(routes + 'account/get/createAccount'));
app.get('/account_activated', require(routes + 'account/get/register'));
app.get('/account/register', require(routes + 'account/get/register'));
Expand Down
65 changes: 0 additions & 65 deletions routes/lobby_api.js

This file was deleted.