enable global error-handler again + some error-logging improvements #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brutus5000
reviewed
Nov 13, 2023
Comment on lines
+327
to
+329
| if (res.headersSent) { | ||
| return next(err); | ||
| } |
There was a problem hiding this comment.
there is an issue if the error is thrown after the server already sent the http-header, in this case it's better to let express handle the error, see https://expressjs.com/en/guide/error-handling.html
There are some pending issues with the general approach.. how to handle errors if the caller expects json, js etc.
There was a problem hiding this comment.
if you missed it, this function was never called (thus no error handling on production) bc. of express expecting 4 parameters:
Define error-handling middleware functions in the same way as other middleware functions, except error-handling functions have four arguments instead of three: (err, req, res, next)
Brutus5000
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global error-handler was disabled due some missing parameters (god knows i like this kind of magic).
Improved the logs to be more "production" friendly.