Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added isAuthenticated middleware #481

Merged
merged 1 commit into from Nov 21, 2023

Conversation

fcaps
Copy link
Collaborator

@fcaps fcaps commented Nov 20, 2023

closes #479
Redirecting after login is now possible, but i opted to not directly add this to every route.

@Brutus5000
Copy link
Member

Brutus5000 commented Nov 21, 2023

Uh we got a merge conflict.

but i opted to not directly add this to every route

If I understand the correctly, if you don't define anything you get back to the original url. Is that right? In that case, where else would we need to add this to routes?

@fcaps fcaps force-pushed the feature/login-after-redirect branch from b38d161 to 9224ff7 Compare November 21, 2023 07:54
@fcaps
Copy link
Collaborator Author

fcaps commented Nov 21, 2023

If I understand the correctly, if you don't define anything you get back to the original url. Is that right? In that case, where else would we need to add this to routes?

yeah, originUrl is the "current" path.
already added the middleware in PR #485 to the other routes.

@Brutus5000 Brutus5000 merged commit 429bdf6 into FAForever:develop Nov 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect User After Login
2 participants