Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactivate clan-list/view with the new m2m client #519

Merged
merged 2 commits into from Dec 3, 2023

Conversation

fcaps
Copy link
Collaborator

@fcaps fcaps commented Dec 3, 2023

closes #459
related #445

as a part of the refactoring i had to remove the old code (it was not maintainable anymore) and updated it to work with the new m2m client, services and repository pattern.

The single view: (the leave clan is not implemented and will be done in another ticket)
image

List view:
image

The filter is instant (no backend call) and is bound to filter tag, name or leader.

Caching for clans/clan is 60min and should be purged if we add the clan-management again, so we purge only if needed.
There is also the possibility to "warmup" the clan cache, but this could be handled in another ticket.

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (d231e86) 46.26% compared to head (28e374e) 48.12%.

Files Patch % Lines
src/backend/services/DataRepository.js 62.29% 11 Missing and 12 partials ⚠️
src/backend/routes/views/dataRouter.js 33.33% 6 Missing ⚠️
src/backend/routes/views/clanRouter.js 50.00% 1 Missing and 2 partials ⚠️
src/backend/services/ClanService.js 86.95% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #519      +/-   ##
===========================================
+ Coverage    46.26%   48.12%   +1.86%     
===========================================
  Files           56       58       +2     
  Lines         1204     1309     +105     
  Branches       131      154      +23     
===========================================
+ Hits           557      630      +73     
- Misses         633      649      +16     
- Partials        14       30      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcaps
Copy link
Collaborator Author

fcaps commented Dec 3, 2023

@beckpaul you wanna try reviewing this?

@fcaps
Copy link
Collaborator Author

fcaps commented Dec 3, 2023

i know i should cover the error-cases a bit better, but somehow my joy writing tests has limits...

@fcaps fcaps mentioned this pull request Dec 3, 2023
@fcaps fcaps merged commit c8ccf5d into FAForever:develop Dec 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clan/{id} was removed, but game-client still uses it
1 participant