Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor clan management #523

Merged
merged 1 commit into from Dec 5, 2023
Merged

Conversation

fcaps
Copy link
Collaborator

@fcaps fcaps commented Dec 5, 2023

closes #445

refactored all clan pages except transfer leadership.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 152 lines in your changes are missing coverage. Please review.

Comparison is base (db94e34) 44.75% compared to head (d709955) 41.79%.

Files Patch % Lines
src/backend/services/ClanManagementRepository.js 0.00% 26 Missing ⚠️
src/backend/routes/views/clans/view.js 31.03% 17 Missing and 3 partials ⚠️
src/backend/routes/views/clans/join.js 10.52% 17 Missing ⚠️
src/backend/routes/views/clans/inviteAccept.js 11.11% 16 Missing ⚠️
src/backend/routes/views/clans/kick.js 11.11% 16 Missing ⚠️
src/backend/routes/views/clans/leave.js 11.11% 16 Missing ⚠️
src/backend/routes/views/clans/invite.js 21.05% 15 Missing ⚠️
src/backend/services/ClanManagementService.js 0.00% 14 Missing ⚠️
src/backend/services/DataRepository.js 25.00% 9 Missing ⚠️
src/backend/routes/views/clans/get/manage.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #523      +/-   ##
===========================================
- Coverage    44.75%   41.79%   -2.96%     
===========================================
  Files           64       70       +6     
  Lines         1506     1682     +176     
  Branches       183      220      +37     
===========================================
+ Hits           674      703      +29     
- Misses         801      947     +146     
- Partials        31       32       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcaps fcaps merged commit e954663 into FAForever:develop Dec 5, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple features (clans, leaderboard etc.) not working.
1 participant