Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clan Ownership refactor #532

Merged
merged 11 commits into from Jan 8, 2024
Merged

Conversation

beckpaul
Copy link
Collaborator

@beckpaul beckpaul commented Dec 15, 2023

Closes #524

Adds a "make leader" button to the view clan page for clan leaders. Allows leaders to transfer leadership in clans utilizing the new standards and helper functions.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (b8240d5) 41.17% compared to head (5849323) 40.55%.

Files Patch % Lines
src/backend/routes/views/clans/transfer.js 12.50% 14 Missing ⚠️
src/backend/services/ClanManagementRepository.js 0.00% 9 Missing ⚠️
src/backend/services/ClanManagementService.js 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #532      +/-   ##
===========================================
- Coverage    41.17%   40.55%   -0.63%     
===========================================
  Files           71       72       +1     
  Lines         1734     1768      +34     
  Branches       210      214       +4     
===========================================
+ Hits           714      717       +3     
- Misses         988     1019      +31     
  Partials        32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beckpaul beckpaul self-assigned this Dec 15, 2023
@beckpaul beckpaul changed the title Clan onwership refactor Clan Ownership refactor Dec 30, 2023
@beckpaul
Copy link
Collaborator Author

beckpaul commented Dec 30, 2023

Screen.Recording.2023-12-30.at.13.59.33.mov

@beckpaul beckpaul marked this pull request as ready for review December 30, 2023 19:03
@beckpaul beckpaul requested a review from fcaps January 7, 2024 22:06
@fcaps fcaps merged commit d6d1114 into FAForever:develop Jan 8, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Clan] transfer ownership
2 participants