Added the SemanticArtefact class definition to MOD 2.0 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @biswanathdutta, would you be able to review this PR please? Thanks |
biswanathdutta
previously approved these changes
Nov 29, 2023
biswanathdutta
dismissed
their stale review
There are issues. So dismissing the first review. I am going to provide my specific remarks.
There was a problem hiding this comment.
@agbeltran we should add SemanticArtefact description. Also, add its subClassOf information.
The definition may be moved to the class section (below line number 2981) for its better management.
|
thanks @biswanathdutta - I added the definition and moved it to the classes section - please note that this is a fix of V2.0 but this will soon be replaced with version 3.0 - it is only to address the issue raised for this version. I would like to merge this asap. |
|
thanks @antony-wilson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving issue #40