Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/precommit hook #129

Merged
merged 4 commits into from
Nov 18, 2021
Merged

Feature/precommit hook #129

merged 4 commits into from
Nov 18, 2021

Conversation

bruvio
Copy link
Collaborator

@bruvio bruvio commented Nov 18, 2021

added pre commit hooks and started refactoring of code

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #129 (cfdad39) into main (bf46331) will decrease coverage by 0.06%.
The diff coverage is 77.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   73.06%   72.99%   -0.07%     
==========================================
  Files          23       23              
  Lines        2892     2885       -7     
==========================================
- Hits         2113     2106       -7     
  Misses        779      779              
Impacted Files Coverage Δ
fair/__init__.py 100.00% <ø> (ø)
fair/parsing/__init__.py 100.00% <ø> (ø)
fair/registry/sync.py 18.98% <15.38%> (ø)
fair/parsing/globbing.py 48.78% <40.00%> (-1.22%) ⬇️
fair/registry/versioning.py 83.92% <60.00%> (-0.29%) ⬇️
fair/session.py 64.05% <72.30%> (ø)
fair/registry/storage.py 69.79% <74.00%> (-0.32%) ⬇️
fair/configuration.py 71.63% <75.86%> (-0.17%) ⬇️
fair/user_config.py 79.53% <76.60%> (ø)
fair/history.py 85.96% <78.57%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7349d22...cfdad39. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 4 Security Hotspots
Code Smell A 32 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@bruvio bruvio merged commit b214da5 into main Nov 18, 2021
@kzscisoft kzscisoft deleted the feature/precommit-hook branch November 25, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant