Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all constants to common and ensure init before run #132

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

kzscisoft
Copy link
Collaborator

closes #111

@sonarcloud
Copy link

sonarcloud bot commented Nov 19, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #132 (bc20bca) into main (df4449d) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   72.98%   72.96%   -0.02%     
==========================================
  Files          23       23              
  Lines        2887     2889       +2     
==========================================
+ Hits         2107     2108       +1     
- Misses        780      781       +1     
Impacted Files Coverage Δ
fair/cli.py 54.34% <ø> (ø)
fair/registry/server.py 82.77% <0.00%> (-0.47%) ⬇️
fair/session.py 63.97% <ø> (ø)
fair/common.py 97.26% <85.71%> (-1.23%) ⬇️
fair/configuration.py 71.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4449d...bc20bca. Read the comment docs.

@kzscisoft kzscisoft merged commit b2f4ab8 into main Nov 19, 2021
@kzscisoft kzscisoft deleted the hotfix/ensure-init branch November 23, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traceback when user tries to run before initialisation
1 participant