Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-initialisation registry install fix #144

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

kzscisoft
Copy link
Collaborator

Fixes a bug where the global config is partially made when the registry is installed, this causes things to break later on if purging etc.

@kzscisoft kzscisoft added the bug Something isn't working label Nov 26, 2021
@kzscisoft kzscisoft added this to the v0.3 Release milestone Nov 26, 2021
@kzscisoft kzscisoft added this to In Progress in FAIR CLI TODO via automation Nov 26, 2021
@kzscisoft kzscisoft changed the base branch from main to develop November 26, 2021 13:38
@sonarcloud
Copy link

sonarcloud bot commented Nov 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #144 (942a059) into develop (e787777) will decrease coverage by 0.09%.
The diff coverage is 37.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #144      +/-   ##
===========================================
- Coverage    73.15%   73.05%   -0.10%     
===========================================
  Files           24       24              
  Lines         3047     3051       +4     
===========================================
  Hits          2229     2229              
- Misses         818      822       +4     
Impacted Files Coverage Δ
fair/session.py 63.09% <0.00%> (-0.91%) ⬇️
fair/registry/server.py 82.77% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e787777...942a059. Read the comment docs.

@kzscisoft kzscisoft merged commit c198924 into develop Nov 26, 2021
@kzscisoft kzscisoft deleted the kzscisoft/pre-init-registry-install-fix branch November 26, 2021 13:55
@kzscisoft kzscisoft moved this from In Progress to Done in FAIR CLI TODO Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant