Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/precommit dev #165

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Feature/precommit dev #165

merged 2 commits into from
Dec 6, 2021

Conversation

bruvio
Copy link
Collaborator

@bruvio bruvio commented Dec 4, 2021

moved pre-commit dependencies to dev

updated precommit hooks rules for black to limit max length to 79

manually run hooks
tested locally

@bruvio bruvio requested a review from kzscisoft December 4, 2021 14:47
@sonarcloud
Copy link

sonarcloud bot commented Dec 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@bruvio bruvio enabled auto-merge December 4, 2021 14:48
@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

Merging #165 (7f76f82) into main (59148e1) will decrease coverage by 0.00%.
The diff coverage is 71.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   72.93%   72.92%   -0.01%     
==========================================
  Files          23       23              
  Lines        2893     2892       -1     
==========================================
- Hits         2110     2109       -1     
  Misses        783      783              
Impacted Files Coverage Δ
fair/common.py 95.89% <0.00%> (ø)
fair/exceptions.py 80.32% <ø> (ø)
fair/parsing/globbing.py 48.78% <ø> (ø)
fair/registry/sync.py 18.98% <0.00%> (ø)
fair/run.py 78.16% <0.00%> (ø)
fair/session.py 63.89% <47.61%> (ø)
fair/history.py 85.96% <50.00%> (ø)
fair/user_config.py 79.53% <63.63%> (ø)
fair/registry/requests.py 84.97% <75.00%> (ø)
fair/registry/storage.py 69.79% <85.71%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59148e1...7f76f82. Read the comment docs.

@bruvio bruvio merged commit 7a9754f into main Dec 6, 2021
@bruvio bruvio deleted the feature/precommit-dev branch December 6, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants