Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom virtual environment class to fix venv python exe setup #187

Merged
merged 3 commits into from
Jan 19, 2022

Conversation

kzscisoft
Copy link
Collaborator

Currently when building fair binaries venv thinks it is being called by python itself and not fair as such it tries to use fair to pip install and fails. This fix creates a modded version of EnvBuilder which points to the actual python executable.

@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #187 (638faf3) into develop (d214012) will increase coverage by 0.17%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #187      +/-   ##
===========================================
+ Coverage    74.38%   74.55%   +0.17%     
===========================================
  Files           25       26       +1     
  Lines         3568     3600      +32     
===========================================
+ Hits          2654     2684      +30     
- Misses         914      916       +2     
Impacted Files Coverage Δ
fair/virtualenv.py 92.00% <92.00%> (ø)
fair/cli.py 54.95% <100.00%> (+0.64%) ⬆️
fair/registry/server.py 84.61% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d214012...638faf3. Read the comment docs.

@kzscisoft kzscisoft merged commit 73d600e into develop Jan 19, 2022
@kzscisoft kzscisoft deleted the kzscisoft/fix-binary-wrong-python-venv branch January 19, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant