Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx test, update citations #251

Merged
merged 1 commit into from
Jun 20, 2022
Merged

FIx test, update citations #251

merged 1 commit into from
Jun 20, 2022

Conversation

RyanJField
Copy link
Collaborator

No description provided.

@RyanJField RyanJField requested a review from bruvio June 20, 2022 16:15
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RyanJField RyanJField mentioned this pull request Jun 20, 2022
Closed
bruvio
bruvio approved these changes Jun 20, 2022
View reviewed changes
Copy link
Collaborator

@bruvio bruvio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you are telling me that what was missing was keyword parameter (local =....) ? :)

the change in the init is would say is not needed right as python automatically returns a none

thanks for the fix

@bruvio bruvio merged commit eaf1d15 into develop Jun 20, 2022
@RyanJField
Copy link
Collaborator Author

Yeah it was an issue with the keyword argument. I assumed python would by default return none but I’ve been programming in C++ recently which is more strict about returns etc.

@RyanJField RyanJField deleted the hotfix/test_fix branch June 20, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvio bruvio bruvio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RyanJField @bruvio