Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap Boolean for Primary in f string #271

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Conversation

RyanJField
Copy link
Collaborator

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #271 (0d6bd02) into develop (c64ace4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #271   +/-   ##
========================================
  Coverage    69.19%   69.19%           
========================================
  Files           27       27           
  Lines         3688     3688           
========================================
  Hits          2552     2552           
  Misses        1136     1136           
Impacted Files Coverage Δ
fair/registry/storage.py 76.60% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@richardreeve
Copy link
Member

I presume this won't wrap a string (e.g. "False" becomes '\"False\"' or something) in a string btw? I have no idea what f'xxx' does... if not, then this looks good to me.

@RyanJField
Copy link
Collaborator Author

RyanJField commented Sep 26, 2022

I presume this won't wrap a string (e.g. "False" becomes '\"False\"' or something) in a string btw? I have no idea what f'xxx' does... if not, then this looks good to me.

It’s an f string (formatted string), It will drop the “” as they’re dropped when read from the yaml and f strings only include the sting value and not the quotation marks.

@RyanJField RyanJField merged commit df97076 into develop Sep 26, 2022
@RyanJField RyanJField deleted the hotix/primary-fix branch September 26, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants