Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

125 merge substrate classes from pld and movpe and place it under ikz category #134

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

aalbino2
Copy link
Collaborator

No description provided.

@aalbino2 aalbino2 force-pushed the 125-merge-substrate-classes-from-pld-and-movpe-and-place-it-under-ikz-category branch from 89a0710 to d00f331 Compare February 22, 2024 13:42
@aalbino2
Copy link
Collaborator Author

I'm basically done. I tried the following solution at the beginning for the SubstratePreparation class:

class SubstratePreparationStep(Activity):
    m_def = Section()

class EtchingForSubstrate(SubstratePreparationStep, Etching):
    pass

It was not convenient because we would have seen twice each Activity listed in the IKZ category, e. g., EtchingForSubstrate and Etching.

So I went for the solution in which we have SubstratePreparationStep class in basesection.py and we stick it to whatever class will be needed into a SubstratePreparation

@aalbino2 aalbino2 self-assigned this Feb 22, 2024
@aalbino2
Copy link
Collaborator Author

@ka-sarthak I think when solving the #126 you could place the XRD stuff in the new characterization submodule here in IKZ_plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merge substrate classes from PLD and MOVPE and place it under IKZ category
1 participant